Travis ci use ctest #316
Merged
Travis ci use ctest #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just a possibility. If you would rather us not disable tests, that's fine - I can close this. Just let me know. |
psavery
force-pushed
the
travis-ci-use-ctest
branch
from
88341b2 to
8e0f030
Compare
psavery
force-pushed
the
travis-ci-use-ctest
branch
2 times, most recently
from
172864a to
3665303
Compare
|
Since PR #323 was accepted, I modified this PR so that the only change is that avogadrolibs now runs ctest instead of running the different tests directly. If the tests all pass, this PR should be good to go. |
|
If ctest is ran directly, one of the tests fails with the following error: I will see if I can fix it with xvfb-run. |
We are using xvfb-run because we need a display for the QtGui-FileBrowseWidget test. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
travis-ci-use-ctest
branch
from
3665303 to
807f3fe
Compare
|
xvbf-run seemed to fix it. This is ready for review. |
|
I realize this PR addresses Travis, but can we use ctest with Appveyor? |
|
I'm okay with the change, but I'd prefer to leave to @cryos to sign off on this. |
|
I added a PR for AppVeyor as well: PR #330. |
cryos
approved these changes
Jul 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possibility to allow us to immediately use ctest without fixing the broken tests.
I wish ctest or gtest had an equivalent to pytest's 'xfail', but this is the closest I could get to
it. It prints out a message saying which tests are disabled at the end of each run. It can
function as a reminder to eventually fix them.
This builds off of PR #313.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.